Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix networkid #205

Merged
merged 2 commits into from
Nov 29, 2023
Merged

fix: fix networkid #205

merged 2 commits into from
Nov 29, 2023

Conversation

ibrizsabin
Copy link
Collaborator

@ibrizsabin ibrizsabin commented Nov 29, 2023

Description:

Commit Message

fix: update network id

see the guidelines for commit messages.

Changelog Entry

version: <log entry>

Checklist:

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Merging #205 (09df587) into release/v1.1.0-hotfix (e95a4f8) will decrease coverage by 0.11%.
The diff coverage is 50.00%.

Additional details and impacted files

Impacted file tree graph

@@                     Coverage Diff                     @@
##             release/v1.1.0-hotfix     #205      +/-   ##
===========================================================
- Coverage                    68.83%   68.72%   -0.11%     
  Complexity                      55       55              
===========================================================
  Files                           32       32              
  Lines                         1925     1928       +3     
  Branches                        34       34              
===========================================================
  Hits                          1325     1325              
- Misses                         584      587       +3     
  Partials                        16       16              
Flag Coverage Δ
rust 67.50% <50.00%> (-0.14%) ⬇️
solidity 65.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
contracts/cosmwasm-vm/cw-xcall/src/lib.rs 27.77% <ø> (ø)
contracts/cosmwasm-vm/cw-xcall/src/contract.rs 72.86% <50.00%> (-1.33%) ⬇️

... and 3 files with indirect coverage changes

@ibrizsabin ibrizsabin added the bug Something isn't working label Nov 29, 2023
@ibrizsabin ibrizsabin marked this pull request as ready for review November 29, 2023 07:59
Copy link
Collaborator

@AntonAndell AntonAndell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AntonAndell AntonAndell merged commit 06705e1 into release/v1.1.0-hotfix Nov 29, 2023
17 of 20 checks passed
@AntonAndell AntonAndell deleted the fix/update-networkid branch November 29, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants