Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: multi message rust #171

Conversation

ibrizsabin
Copy link
Collaborator

@ibrizsabin ibrizsabin commented Nov 9, 2023

Description:

Commit Message

type: commit message

see the guidelines for commit messages.

Changelog Entry

version: <log entry>

Checklist:

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@ibrizsabin ibrizsabin changed the title feat: add multi message feat: multi message rust Nov 9, 2023
@pragyanshrestha-ibriz pragyanshrestha-ibriz linked an issue Nov 9, 2023 that may be closed by this pull request
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #171 (28b1eb4) into development/177-xcall-future-proof-messaging (6171a6c) will decrease coverage by 3.97%.
The diff coverage is 61.80%.

❗ Current head 28b1eb4 differs from pull request most recent head f223dde. Consider uploading reports for the commit f223dde to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@                                Coverage Diff                                 @@
##             development/177-xcall-future-proof-messaging     #171      +/-   ##
==================================================================================
- Coverage                                           70.39%   66.42%   -3.97%     
- Complexity                                             36       61      +25     
==================================================================================
  Files                                                  34       37       +3     
  Lines                                                1888     2088     +200     
  Branches                                               10       29      +19     
==================================================================================
+ Hits                                                 1329     1387      +58     
- Misses                                                553      687     +134     
- Partials                                                6       14       +8     
Flag Coverage Δ
rust 64.44% <50.94%> (-3.16%) ⬇️
solidity 65.02% <ø> (-16.46%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
contracts/cosmwasm-vm/cw-xcall/src/assertion.rs 71.18% <100.00%> (-20.34%) ⬇️
contracts/cosmwasm-vm/cw-xcall/src/execute_call.rs 78.57% <100.00%> (ø)
contracts/cosmwasm-vm/cw-xcall/src/lib.rs 27.77% <ø> (ø)
contracts/cosmwasm-vm/cw-xcall/src/types/result.rs 52.30% <100.00%> (ø)
...acts/cosmwasm-vm/cw-xcall/src/send_call_message.rs 96.72% <96.00%> (+0.05%) ⬆️
...ontracts/cosmwasm-vm/cw-xcall/src/types/message.rs 43.28% <54.54%> (-4.67%) ⬇️
...ontracts/cosmwasm-vm/cw-xcall/src/types/request.rs 76.00% <73.68%> (-1.97%) ⬇️
...ts/cosmwasm-vm/cw-xcall/src/handle_call_message.rs 8.91% <0.00%> (ø)
...tracts/cosmwasm-vm/cw-xcall-lib/src/message/mod.rs 57.14% <57.14%> (ø)
...s/cosmwasm-vm/cw-xcall-lib/src/message/msg_type.rs 50.00% <50.00%> (ø)
... and 4 more

... and 4 files with indirect coverage changes

@ibrizsabin ibrizsabin marked this pull request as ready for review November 10, 2023 15:55
@AntonAndell AntonAndell linked an issue Nov 13, 2023 that may be closed by this pull request
Copy link
Collaborator

@AntonAndell AntonAndell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it would work with the same flow internally. But implementing a new message type seems complicated and the flow is somewhat hard to follow. You can't really see what each message does clearly

@github-actions github-actions bot added documentation Improvements or additions to documentation and removed scripts labels Nov 23, 2023
Base automatically changed from feature/multi-message-xcall to development/177-xcall-future-proof-messaging December 1, 2023 11:53
@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Dec 1, 2023
@ibrizsabin ibrizsabin merged commit 78c8955 into development/177-xcall-future-proof-messaging Dec 1, 2023
9 checks passed
@ibrizsabin ibrizsabin deleted the feat/multi-message-rust branch December 1, 2023 11:59
bishalbikram pushed a commit that referenced this pull request Oct 2, 2024
* feat: Add message types to xCall

* feat: add multi message

* fix: fix test

* refactor: csresponse to scresult

* refactor: csmessage type

* docs: Add new message strucute to xCall design doc

* refactor: rename result

* fix: fix test

* chore: cleanup

* test: add test for envelope encoding

* test: add envelope encoding test

* chore: fix lint

* feat: Add message types to xCall

* fix: remove should persist

* fix: remove duplicate merge

* fix: encode length

* fix: remove msg type

* test: fix tests

* fix: Revert change of rollback db name

Break out db paths into static String variables

* Update docs/adr/xcall.md

Co-authored-by: AntonAndell <[email protected]>

---------

Co-authored-by: AntonAndell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rust: Implement new message flow Rust Contracts for xCall update for Future proof messaging
2 participants