-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: multi message rust #171
feat: multi message rust #171
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## development/177-xcall-future-proof-messaging #171 +/- ##
==================================================================================
- Coverage 70.39% 66.42% -3.97%
- Complexity 36 61 +25
==================================================================================
Files 34 37 +3
Lines 1888 2088 +200
Branches 10 29 +19
==================================================================================
+ Hits 1329 1387 +58
- Misses 553 687 +134
- Partials 6 14 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it would work with the same flow internally. But implementing a new message type seems complicated and the flow is somewhat hard to follow. You can't really see what each message does clearly
e74e470
to
146d710
Compare
contracts/cosmwasm-vm/cw-xcall-lib/src/message/call_message_rollback.rs
Outdated
Show resolved
Hide resolved
Break out db paths into static String variables
…-project/xCall into feat/multi-message-rust
Co-authored-by: AntonAndell <[email protected]>
78c8955
into
development/177-xcall-future-proof-messaging
* feat: Add message types to xCall * feat: add multi message * fix: fix test * refactor: csresponse to scresult * refactor: csmessage type * docs: Add new message strucute to xCall design doc * refactor: rename result * fix: fix test * chore: cleanup * test: add test for envelope encoding * test: add envelope encoding test * chore: fix lint * feat: Add message types to xCall * fix: remove should persist * fix: remove duplicate merge * fix: encode length * fix: remove msg type * test: fix tests * fix: Revert change of rollback db name Break out db paths into static String variables * Update docs/adr/xcall.md Co-authored-by: AntonAndell <[email protected]> --------- Co-authored-by: AntonAndell <[email protected]>
Description:
Commit Message
see the guidelines for commit messages.
Changelog Entry
Checklist: