Skip to content
This repository has been archived by the owner on Dec 15, 2021. It is now read-only.

[IS-1229] added log for future anaysis #586

Merged
merged 3 commits into from
Nov 9, 2020

Conversation

yakkle
Copy link
Member

@yakkle yakkle commented Oct 26, 2020

changes

  • improved log message when called grpc methods
  • set grpc compression as Deflate
  • updated logging format(fixed length of loglevel, add funcName)
  • refactoring codes

@yakkle yakkle requested a review from a team October 26, 2020 09:25
@yakkle yakkle self-assigned this Oct 26, 2020
@yakkle yakkle force-pushed the feature/IS-1229-inversion-unconfirmed-block branch from 649f793 to 3bf00ef Compare November 3, 2020 03:27
Comment on lines 417 to 418
elif response.response_code in (message_code.Response.fail_not_enough_data,
message_code.Response.fail_wrong_block_hash):
Copy link
Member Author

@yakkle yakkle Nov 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
elif response.response_code in (message_code.Response.fail_not_enough_data,
message_code.Response.fail_wrong_block_hash):
elif response.response_code in (message_code.Response.fail_not_enough_data,
message_code.Response.fail_wrong_block_height):

 - improved log message when called grpc methods
 - set grpc compression as `Deflate`
 - updated logging format(fixed length of loglevel, add funcName)
 - refactoring codes
@yakkle yakkle force-pushed the feature/IS-1229-inversion-unconfirmed-block branch from cc2e333 to 9c97c9b Compare November 9, 2020 08:21
@yakkle yakkle merged commit 24a8c7b into develop Nov 9, 2020
@yakkle yakkle deleted the feature/IS-1229-inversion-unconfirmed-block branch November 10, 2020 10:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants