Skip to content
This repository has been archived by the owner on Dec 15, 2021. It is now read-only.

[LC-909] Remove dependency (py-leveldb) #489

Merged
merged 1 commit into from
Mar 13, 2020

Conversation

metalg0su
Copy link
Contributor

@metalg0su metalg0su commented Mar 11, 2020

Goal

  • Remove py-leveldb dependency and its followings from Loopchain

Since Loopchain uses leveldb powered by plyvel, py-leveldb is no more
needed.

@metalg0su metalg0su self-assigned this Mar 11, 2020
@metalg0su metalg0su requested a review from a team March 11, 2020 06:38
@metalg0su metalg0su marked this pull request as ready for review March 11, 2020 06:38
Copy link
Member

@yakkle yakkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@yakkle
Copy link
Member

yakkle commented Mar 12, 2020

please squash to single commit.
why-squash-git-commits-for-pull-requests

 - Since Loopchain uses leveldb powered by plyvel, py-leveldb is no more
needed.
@metalg0su metalg0su merged commit 727ace8 into icon-project:develop Mar 13, 2020
@metalg0su metalg0su deleted the feature/LC-909 branch March 13, 2020 05:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants