This repository has been archived by the owner on Dec 15, 2021. It is now read-only.
[LC-272] fixed to add limited tx_items to queue #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metalg0su
reviewed
Jan 14, 2020
metalg0su
reviewed
Jan 14, 2020
yakkle
force-pushed
the
feature/LC-272
branch
from
c383894
to
9cde387
Compare
yakkle
changed the title
yakkle
force-pushed
the
feature/LC-272
branch
from
9cde387
to
6734485
Compare
yakkle
force-pushed
the
feature/LC-272
branch
from
6734485
to
0a248d0
Compare
yakkle
force-pushed
the
feature/LC-272
branch
from
0a248d0
to
3b66b8d
Compare
metalg0su
reviewed
Jan 30, 2020
metalg0su
reviewed
Jan 30, 2020
metalg0su
reviewed
Jan 30, 2020
metalg0su
reviewed
Jan 30, 2020
metalg0su
reviewed
Jan 30, 2020
metalg0su
reviewed
Jan 30, 2020
yakkle
commented
Jan 31, 2020
| class TestTxMessages: | ||
| tx_count = 50 | ||
|
|
||
| @pytest.mark.parametrize("tx_items", [tx_count], indirect=True) |
There was a problem hiding this comment.
There was a problem hiding this comment.
SUPER USEFUL parametrized fixture!
yakkle
force-pushed
the
feature/LC-272
branch
from
3b66b8d
to
ceb2e3a
Compare
metalg0su
reviewed
Feb 6, 2020
- tx_items has maximum items that not over tx_max_size or tx_max_count - monkeypatch configure value in test_custom_tx_value - fixed blocking issue when set maxsize in TxMessagesQueue
yakkle
force-pushed
the
feature/LC-272
branch
from
424929d
to
2074b56
Compare
metalg0su
approved these changes
Feb 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
current
tx_listadded until over limited size or count from queue.First take it from the queue, then check the status, and then add it back to the queue if the condition is false. So, re-added item is located on last of queue.
will be
Add
tx_itemto a limited size or count.tx_listis now readily available from the queue.