Skip to content
This repository has been archived by the owner on Dec 15, 2021. It is now read-only.

[LC-625] Timer(Service) unit tests #343

Merged
merged 5 commits into from
Feb 21, 2020
Merged

[LC-625] Timer(Service) unit tests #343

merged 5 commits into from
Feb 21, 2020

Conversation

metalg0su
Copy link
Contributor

@metalg0su metalg0su commented Sep 24, 2019 •
edited
Loading

Goal

  • More precise test

Test for callbacks both blocking and coroutine func.

  • Faster Unit test for Timer & TimerService

21+ sec -> 2.0- sec

  • Increase coverage for Timer & TimerService

79% -> 96%+

@metalg0su metalg0su changed the title [LC-625] Make timer unit test faster [LC-625] Make faster unit tests for TimerService Sep 24, 2019
@metalg0su metalg0su force-pushed the feature/LC-625-timer-service-test branch 2 times, most recently from 229e8f3 to e5e3930 Compare September 25, 2019 07:28
@metalg0su metalg0su marked this pull request as ready for review September 25, 2019 07:38
@metalg0su metalg0su changed the title [LC-625] Make faster unit tests for TimerService [LC-625] Timer(Service) unit tests Sep 25, 2019
@metalg0su metalg0su requested a review from a team September 25, 2019 09:35
@metalg0su metalg0su force-pushed the feature/LC-625-timer-service-test branch 2 times, most recently from 8588e5b to 345186c Compare October 8, 2019 07:51
@metalg0su metalg0su force-pushed the feature/LC-625-timer-service-test branch from 345186c to 020c30c Compare October 21, 2019 09:48
@metalg0su
Copy link
Contributor Author

retest this please

@metalg0su metalg0su force-pushed the feature/LC-625-timer-service-test branch 2 times, most recently from fbfd98f to 5670d65 Compare October 24, 2019 06:45
@metalg0su metalg0su force-pushed the feature/LC-625-timer-service-test branch 2 times, most recently from 031ff11 to 5621e84 Compare November 19, 2019 07:02
@metalg0su metalg0su force-pushed the feature/LC-625-timer-service-test branch from 5621e84 to d71f5a0 Compare November 21, 2019 12:05
@metalg0su metalg0su force-pushed the feature/LC-625-timer-service-test branch from d71f5a0 to 1612291 Compare November 29, 2019 04:16
@metalg0su metalg0su force-pushed the feature/LC-625-timer-service-test branch from 1612291 to 14be479 Compare December 11, 2019 02:57
@metalg0su metalg0su force-pushed the feature/LC-625-timer-service-test branch from 14be479 to 32e52de Compare January 8, 2020 09:18
@metalg0su metalg0su force-pushed the feature/LC-625-timer-service-test branch 3 times, most recently from f8b695a to b38666b Compare January 13, 2020 02:10
@metalg0su metalg0su force-pushed the feature/LC-625-timer-service-test branch from b38666b to 9c47e90 Compare January 29, 2020 06:17
@metalg0su metalg0su self-assigned this Jan 30, 2020
@metalg0su metalg0su force-pushed the feature/LC-625-timer-service-test branch from 9c47e90 to 4a3e388 Compare February 21, 2020 02:51
@metalg0su metalg0su merged commit d1472e3 into develop Feb 21, 2020
@metalg0su metalg0su deleted the feature/LC-625-timer-service-test branch February 21, 2020 08:51
@yakkle yakkle mentioned this pull request Jun 17, 2020
Merged
@yakkle yakkle mentioned this pull request Jul 29, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@windies21 windies21 windies21 approved these changes

Assignees

@metalg0su metalg0su

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@metalg0su @windies21