This repository has been archived by the owner on Dec 15, 2021. It is now read-only.
IS-1230: getPReps returns error with high end ranking. #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endRanking <= 0: Invalid params endRanking > # of candidates (nomal case)
inwonkim
reviewed
Sep 22, 2020
goldworm-icon
suggested changes
Sep 23, 2020
| @@ -633,3 +633,147 @@ def check_query_via_icx_sendtransaction(self, method: str, params: dict, expecte | |||
| func_name=method, | |||
| params=params) | |||
| return self.process_confirm_block_tx([tx], expected_status=expected_status) | |||
|
|
|||
| def test_get_preps_normal(self): | |||
There was a problem hiding this comment.
I want to add the following test-cases
- startRanking or endRanking are less than zero
- startRanking is larger than # of PReps
There was a problem hiding this comment.
append test case.
pass case
- normal
- over endRanking than prep count
else:
- reverse
- overflow
- zero
- negative
edit raise exception message
* Change ranking verification code * Update unit-tests for getPReps
goldworm-icon
approved these changes
Sep 24, 2020
cow-hs
deleted the
IS-1230-get-preps-return-error-with-high-end-ranking
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invalid case
else:
normal case
fixes icon-project/icon-rpc-server#147