Skip to content
This repository has been archived by the owner on Dec 15, 2021. It is now read-only.

IS-931: Implement get inactive p reps api #391

Merged
merged 2 commits into from
Dec 2, 2019
Merged

IS-931: Implement get inactive p reps api #391

merged 2 commits into from
Dec 2, 2019

Conversation

boyeon555
Copy link
Contributor

  • Add get_inactive_preps method on PrepContainer
  • Add tests for the API

@boyeon555
Implement getInactivePReps API
7b3a548 
- Add get_inactive_preps method on PrepContainer
- Add tests for the API
@boyeon555 boyeon555 self-assigned this Nov 29, 2019
Update PRepEngine.handle_get_inactive_preps()
aeb7345 
* Optimize the filtering condition in PRepContainer.get_inactive_preps()
* Add "blockHeight" and "totalDelegated" fields to the response of getInactivePReps request
* Update test_handle_get_inactive_preps in prep/test_engine.py
@goldworm-icon goldworm-icon self-requested a review December 2, 2019 03:31
@cow-hs cow-hs merged commit 591cc66 into develop Dec 2, 2019
@cow-hs cow-hs deleted the IS-931-implement-getInactivePReps-api branch December 2, 2019 04:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@goldworm-icon goldworm-icon goldworm-icon approved these changes

@cow-hs cow-hs cow-hs approved these changes

Assignees

@boyeon555 boyeon555

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@boyeon555 @cow-hs @goldworm-icon