This repository has been archived by the owner on Dec 15, 2021. It is now read-only.
IS-923: Add P-Rep candidates to the result of getPRepTerm API #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
boyeon555
commented
Nov 22, 2019
boyeon555
commented
- Add get_inactive_preps on PrepContainer to return inactive P-Rep list sorted by penalty value and delegated amount
- Add get_inactive_preps on PrepContainer to return inactive P-Rep list sorted by penalty value and delegated amount
- Modified inactive prep logic to check if prep status is not active or penalty reason is block validation
cow-hs
approved these changes
Nov 26, 2019
* Change inactive P-Reps sorting order: (penalty, delegated) -> name * Move inactive P-Reps sorting code to PRepEngine.get_prep_term() * Update the unittest for get_prep_term()
* Return active P-Reps only * Remove obsolete methods from PRepContainer * Add some unittests for PRepEngine.handle_get_prep_term()
cow-hs
approved these changes
Nov 28, 2019
goldworm-icon
deleted the
IS-923-add-candidates-to-preps-of-getPRepTerm
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.