Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow xCall connection configurations when channel is not open #818

Conversation

AntonAndell
Copy link
Collaborator

@AntonAndell AntonAndell commented Jan 4, 2024

Admin can now reconfigure a channel while it is not opened and Owner can now reset or override a channel config

Description

Commit Message

type: commit message

see the guidelines for commit messages.

Changelog Entry

version: <log entry>

Checklist

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines
  • I have added version bump label on PR.

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@AntonAndell AntonAndell linked an issue Jan 4, 2024 that may be closed by this pull request
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 4, 2024
@AntonAndell AntonAndell self-assigned this Jan 4, 2024
ibrizsabin
ibrizsabin previously approved these changes Jan 4, 2024
@AntonAndell AntonAndell force-pushed the 817-allow-for-easier-channel-configurations-in-xcall-connection branch from 341289f to 81b415c Compare January 4, 2024 14:33
ibrizsabin
ibrizsabin previously approved these changes Jan 4, 2024
Admin can now reconfigure a channel while it is not opened and Owner can now reset or override a channel config
@AntonAndell AntonAndell force-pushed the 817-allow-for-easier-channel-configurations-in-xcall-connection branch from 81b415c to d796724 Compare January 4, 2024 15:03
@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2024

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (9a90959) 70.10% compared to head (d796724) 70.25%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #818      +/-   ##
============================================
+ Coverage     70.10%   70.25%   +0.15%     
- Complexity      409      414       +5     
============================================
  Files           155      155              
  Lines         13947    14028      +81     
  Branches        293      292       -1     
============================================
+ Hits           9778     9856      +78     
- Misses         4016     4022       +6     
+ Partials        153      150       -3     
Flag Coverage Δ
java 81.37% <100.00%> (+0.25%) ⬆️
rust 68.38% <78.75%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../cosmwasm-vm/cw-common/src/xcall_connection_msg.rs 40.00% <ø> (ø)
...cts/cosmwasm-vm/cw-xcall-ibc-connection/src/ack.rs 76.19% <100.00%> (ø)
...osmwasm-vm/cw-xcall-ibc-connection/src/ibc_host.rs 100.00% <100.00%> (ø)
...s/cosmwasm-vm/cw-xcall-ibc-connection/src/state.rs 87.05% <100.00%> (+0.14%) ⬆️
.../main/java/ibc/xcall/connection/IBCConnection.java 90.09% <100.00%> (+2.14%) ⬆️
...osmwasm-vm/cw-xcall-ibc-connection/src/contract.rs 60.63% <71.18%> (+2.30%) ⬆️

... and 1 file with indirect coverage changes

Copy link
Collaborator

@ibrizsabin ibrizsabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@ibrizsabin ibrizsabin merged commit 25588a3 into main Jan 11, 2024
9 checks passed
@ibrizsabin ibrizsabin deleted the 817-allow-for-easier-channel-configurations-in-xcall-connection branch January 11, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for easier channel configurations in xcall connection
3 participants