-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow xCall connection configurations when channel is not open #818
Merged
ibrizsabin
merged 1 commit into
main
from
817-allow-for-easier-channel-configurations-in-xcall-connection
Jan 11, 2024
Merged
feat: Allow xCall connection configurations when channel is not open #818
ibrizsabin
merged 1 commit into
main
from
817-allow-for-easier-channel-configurations-in-xcall-connection
Jan 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonAndell
requested review from
redlarva,
ibrizsabin and
nightowl121
as code owners
January 4, 2024 13:23
github-actions
bot
added
the
documentation
Improvements or additions to documentation
label
Jan 4, 2024
ibrizsabin
previously approved these changes
Jan 4, 2024
AntonAndell
force-pushed
the
817-allow-for-easier-channel-configurations-in-xcall-connection
branch
from
January 4, 2024 14:33
341289f
to
81b415c
Compare
ibrizsabin
previously approved these changes
Jan 4, 2024
Admin can now reconfigure a channel while it is not opened and Owner can now reset or override a channel config
AntonAndell
force-pushed
the
817-allow-for-easier-channel-configurations-in-xcall-connection
branch
from
January 4, 2024 15:03
81b415c
to
d796724
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #818 +/- ##
============================================
+ Coverage 70.10% 70.25% +0.15%
- Complexity 409 414 +5
============================================
Files 155 155
Lines 13947 14028 +81
Branches 293 292 -1
============================================
+ Hits 9778 9856 +78
- Misses 4016 4022 +6
+ Partials 153 150 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ibrizsabin
approved these changes
Jan 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good.
ibrizsabin
deleted the
817-allow-for-easier-channel-configurations-in-xcall-connection
branch
January 11, 2024 05:37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Admin can now reconfigure a channel while it is not opened and Owner can now reset or override a channel config
Description
Commit Message
see the guidelines for commit messages.
Changelog Entry
Checklist