Merge pull request #43 from icings/5.x-fix-static-analysis

5.x - Fix static analysis.
icings · Jun 19, 2024 · 6987862 · 6987862
2 parents af239c0 + 4426f83
commit 6987862
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 5 deletions.
diff --git a/phpstan.src.neon b/phpstan.src.neon
@@ -1,3 +1,4 @@
 parameters:
-    checkMissingIterableValueType: false
-    checkGenericClassInNonGenericObjectType: false
+    ignoreErrors:
+        - identifier: missingType.iterableValue
+        - identifier: missingType.generics
diff --git a/phpstan.tests.neon b/phpstan.tests.neon
@@ -1,9 +1,9 @@
 parameters:
-    checkMissingIterableValueType: false
     excludePaths:
         - tests/TestCase/KnpMenuTestCase.php
         - tests/TestCase/Renderer/KnpAbstractRendererTest.php
     ignoreErrors:
+        - identifier: missingType.iterableValue
         - '#PHPUnit\\Framework\\MockObject\\MockObject given#'
         - '#PHPUnit\\Framework\\MockObject\\MockObject::expects\(\)#'
         - '#Call to an undefined method Icings\\Menu\\Matcher\\Voter\\UrlVoter\|PHPUnit\\Framework\\MockObject\\MockObject::matchItem\(\)#'

diff --git a/psalm-baseline.xml b/psalm-baseline.xml
@@ -1,8 +1,19 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<files psalm-version="5.14.1@b9d355e0829c397b9b3b47d0c0ed042a8a70284d">
+<files psalm-version="5.24.0@462c80e31c34e58cc4f750c656be3927e80e550e">
+  <file src="src/Integration/RoutingExtension.php">
+    <RiskyTruthyFalsyComparison>
+      <code><![CDATA[empty($routes)]]></code>
+    </RiskyTruthyFalsyComparison>
+  </file>
+  <file src="src/Renderer/StringTemplateRenderer.php">
+    <RiskyTruthyFalsyComparison>
+      <code><![CDATA[$item->getUri()]]></code>
+      <code><![CDATA[$newTemplates]]></code>
+    </RiskyTruthyFalsyComparison>
+  </file>
   <file src="src/View/Helper/MenuHelper.php">
     <NonInvariantDocblockPropertyType>
-      <code>$_defaultConfig</code>
+      <code><![CDATA[$_defaultConfig]]></code>
     </NonInvariantDocblockPropertyType>
   </file>
 </files>