Expose all error constructors #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #313 +/- ##
=======================================
Coverage 99.21% 99.21%
=======================================
Files 23 23
Lines 7272 7283 +11
=======================================
+ Hits 7215 7226 +11
Misses 51 51
Partials 6 6 ☔ View full report in Codecov by Sentry. |
ichiban
reviewed
Jan 21, 2024
ccamel
force-pushed
the
feat/expose-exception
branch
from
1307bcc
to
3687712
Compare
This includes: existence_error, permission_error, representation_error, resource_error, syntax_error, and evaluation_error.
ccamel
force-pushed
the
feat/expose-exception
branch
from
3687712
to
11c4f43
Compare
|
@ichiban Thanks for the code review and your insightful comments. Much appreciated. I've made the updates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tackles issue #310.
I propose to make all error types public, similar to how
domain_errorand others were previously made accessible. Given our project's significant reliance onichiban/prolog, having access to the entire spectrum of error types used by the library would be highly beneficial for us as developers.This means making these error constructors available for everyone:
existence_error,permission_error,representation_error,resource_error,syntax_error, andevaluation_error.Thanks.