Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize instruction set for slices #287

Merged
merged 7 commits into from
Mar 20, 2023
Merged

Optimize instruction set for slices #287

merged 7 commits into from
Mar 20, 2023

Conversation

ichiban
Copy link
Owner

@ichiban ichiban commented Mar 11, 2023

VM instructions were naively implemented with difference lists. This PR optimize the instructions with slices.

@codecov
Copy link

codecov bot commented Mar 11, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.51 🎉

Comparison is base (a86cad7) 98.59% compared to head (7762597) 99.11%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #287      +/-   ##
==========================================
+ Coverage   98.59%   99.11%   +0.51%     
==========================================
  Files          23       23              
  Lines        7263     7201      -62     
==========================================
- Hits         7161     7137      -24     
+ Misses         85       59      -26     
+ Partials       17        5      -12     
Impacted Files Coverage Δ
engine/clause.go 100.00% <100.00%> (+1.59%) ⬆️
engine/vm.go 94.42% <100.00%> (+9.52%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ichiban ichiban marked this pull request as ready for review March 20, 2023 12:38
@ichiban ichiban merged commit 207281f into main Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant