Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Term must implement WriteTerm() and Compare() #284

Merged
merged 2 commits into from
Feb 8, 2023
Merged

Conversation

ichiban
Copy link
Owner

@ichiban ichiban commented Feb 4, 2023

No description provided.

@codecov
Copy link

codecov bot commented Feb 4, 2023

Codecov Report

Base: 99.24% // Head: 98.59% // Decreases project coverage by -0.65% ⚠️

Coverage data is based on head (3927ec8) compared to base (bdec4d0).
Patch coverage: 94.15% of modified lines in pull request are covered.

❗ Current head 3927ec8 differs from pull request most recent head cef77c4. Consider uploading reports for the commit cef77c4 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #284      +/-   ##
==========================================
- Coverage   99.24%   98.59%   -0.65%     
==========================================
  Files          23       23              
  Lines        7380     7258     -122     
==========================================
- Hits         7324     7156     -168     
- Misses         40       85      +45     
- Partials       16       17       +1     
Impacted Files Coverage Δ
engine/env.go 97.96% <ø> (-0.98%) ⬇️
engine/vm.go 84.89% <13.33%> (-3.48%) ⬇️
engine/variable.go 95.45% <89.28%> (-4.55%) ⬇️
engine/compound.go 92.06% <93.17%> (-7.94%) ⬇️
engine/builtin.go 99.52% <98.79%> (-0.08%) ⬇️
engine/atom.go 100.00% <100.00%> (ø)
engine/exception.go 100.00% <100.00%> (ø)
engine/float.go 97.56% <100.00%> (+97.56%) ⬆️
engine/integer.go 97.22% <100.00%> (+97.22%) ⬆️
engine/stream.go 100.00% <100.00%> (ø)
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ichiban ichiban marked this pull request as ready for review February 8, 2023 00:57
@ichiban ichiban merged commit 146378f into main Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant