Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify env.Unify() by unexposing occursCheck flag #269

Merged
merged 2 commits into from
Dec 2, 2022

Conversation

ichiban
Copy link
Owner

@ichiban ichiban commented Dec 1, 2022

No description provided.

@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

Base: 99.06% // Head: 99.06% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (51aa675) compared to base (8dff549).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #269   +/-   ##
=======================================
  Coverage   99.06%   99.06%           
=======================================
  Files          22       22           
  Lines        7162     7166    +4     
=======================================
+ Hits         7095     7099    +4     
  Misses         50       50           
  Partials       17       17           
Impacted Files Coverage Δ
engine/builtin.go 99.09% <100.00%> (ø)
engine/env.go 98.94% <100.00%> (+<0.01%) ⬆️
engine/vm.go 88.36% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ichiban ichiban marked this pull request as ready for review December 2, 2022 00:03
@ichiban ichiban merged commit 46b6c0d into main Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant