Merge pull request #14 from nickvergessen/PHP-8.4

feat: Add PHP 8.4 support
icewind1991 · Nov 8, 2024 · 3865288 · 3865288
2 parents 8339181 + 2b4e9a4
commit 3865288
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -7,7 +7,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        php-versions: ['7.4', '8.0']
+        php-versions: ['7.4', '8.0', '8.4']
 
     steps:
       - uses: actions/checkout@v2

diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
@@ -6,7 +6,7 @@ jobs:
     runs-on: ubuntu-20.04
     strategy:
       matrix:
-        php-versions: ['7.4', '8.0']
+        php-versions: ['7.4', '8.0', '8.4']
     name: php${{ matrix.php-versions }} lint
     steps:
     - name: Checkout

diff --git a/src/Query/Scope.php b/src/Query/Scope.php
@@ -51,7 +51,7 @@ class Scope {
 	 * @param int|string $depth
 	 * @param string|null $path
 	 */
-	public function __construct(string $href = '', $depth = 1, string $path = null) {
+	public function __construct(string $href = '', $depth = 1, ?string $path = null) {
 		$this->href = $href;
 		$this->depth = $depth;
 		$this->path = $path;

diff --git a/src/XML/QueryDiscoverResponse.php b/src/XML/QueryDiscoverResponse.php
@@ -38,7 +38,7 @@ class QueryDiscoverResponse extends Response {
 	 * @param BasicSearchSchema|null $schema
 	 * @param null|int|string $httpStatus
 	 */
-	public function __construct($href, BasicSearchSchema $schema = null, $httpStatus = null) {
+	public function __construct($href, ?BasicSearchSchema $schema = null, $httpStatus = null) {
 		if ($httpStatus !== null) {
 			$httpStatus = (string)$httpStatus;
 		}