Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove existing deprecations from icepyx v1.x #640

Open
wants to merge 7 commits into
base: development
Choose a base branch
from

Conversation

JessicaS11
Copy link
Member

@JessicaS11 JessicaS11 commented Jan 21, 2025

Several kwargs and functions were marked as deprecated in icepyx v1.x. This removes anything with a deprecation warning for improved clarity moving forward with the transition to v2.

NOTICE: this may break a few cells or steps within tutorial notebooks. Since they will soon be heavily edited as part of the transition, this is not considered a concern for this PR.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

github-actions bot commented Jan 21, 2025

Binder 👈 Launch a binder notebook on this branch for commit 797113f

I will automatically update this comment whenever this PR is modified

Binder 👈 Launch a binder notebook on this branch for commit b09babd

Binder 👈 Launch a binder notebook on this branch for commit 8e24911

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.90%. Comparing base (2f1875a) to head (8e24911).

Additional details and impacted files
@@               Coverage Diff               @@
##           development     #640      +/-   ##
===============================================
- Coverage        71.78%   66.90%   -4.89%     
===============================================
  Files               38       35       -3     
  Lines             3137     3058      -79     
  Branches           426      422       -4     
===============================================
- Hits              2252     2046     -206     
- Misses             775      925     +150     
+ Partials           110       87      -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JessicaS11 JessicaS11 requested a review from asteiker January 24, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant