-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add capability to created wanted variables list with an explicit list of paths #508
Open
andypbarrett
wants to merge
15
commits into
development
Choose a base branch
from
add-variable-path-list
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 13 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
38968f9
add path_list kwarg to append
a40f104
parse path_list in var_list, beam_list and keyword_list
00ca183
Replace assertion with if statement. Add extra kwarg check
0f9f579
add example to docstring
1342525
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 456bb30
GitHub action UML generation auto-update
rwegener2 f5bac72
Update icepyx/core/variables.py
andypbarrett acb5a52
Update icepyx/core/variables.py
andypbarrett 4dd740b
Apply suggestions from code review
andypbarrett 7603309
Merge branch 'development' into add-variable-path-list
JessicaS11 74fac11
remove non-module warning for append
4054e1f
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 4824bd4
Merge branch 'development' into add-variable-path-list
JessicaS11 1d868bd
add path_list examples to notebook
JessicaS11 e294e31
clear some cell outputs
JessicaS11 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went to add the new example in the docstring to the variables tutorial notebook it raised 2 issues:
path_list
input on ATL06 fails because it's got four layers of variables, not the three we collect here.I haven't reminded myself of how we handle this in general in the module, so that may recommend a solution for (2). (1) is easy if we just sub in another list.