Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: ability to specify the number of visible numbers in the spinner #25

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

dariusdav
Copy link

I've tried to change as little as possible of the original code.
Whats changed:

  • added optional parameter: "numberOfVisibleNums" with default value 3 which should make it so it is not a breaking change for existing use-cases. (tested on Android emulator)
  • swapped "magic numbers" that were tied to 3 visible digits with a variable "offset" or direct calculations by using "widget.numberOfVisibleNums".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant