Skip to content
This repository has been archived by the owner on Aug 13, 2024. It is now read-only.

feat: Implement rest catalog tables and add test framework #179

Merged
merged 2 commits into from
Sep 5, 2023
Merged

feat: Implement rest catalog tables and add test framework #179

merged 2 commits into from
Sep 5, 2023

Conversation

liurenjie1024
Copy link
Contributor

Close #175

  1. Implement list tables api.
  2. Use docker compose rather testcontainers to setup test. I realized that in fact we can run docker compose in parallel and avoid confliction.
  3. Setup test framework.

ZENOTME
ZENOTME approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@ZENOTME ZENOTME left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@liurenjie1024 liurenjie1024 merged commit 6035b7b into icelake-io:main Sep 5, 2023
3 checks passed
@liurenjie1024 liurenjie1024 deleted the renjie/issue-175 branch September 5, 2023 23:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ZENOTME ZENOTME ZENOTME approved these changes

@Xuanwo Xuanwo Awaiting requested review from Xuanwo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement trivial catalog methods and set up ci.
2 participants
@liurenjie1024 @ZENOTME