Skip to content

Conversation

@gssbzn
Copy link

@gssbzn gssbzn commented Oct 2, 2018

Versions of Ruby before 2.3 have reach EOL and should not be supported anymore
Versions of Rails before 4.2 have reach EOL and should not be supported anymore (4.2 soon to follow)

While dropping support to old versions bring the code base to more current standard styles and practices

  • Drop deprecated has_rdoc and test_files from gemspec
  • Freeze constants to avoid manipulation of arrays or hashes
  • Update hash style to drop rockets

And others

Drop ruby < 2.3
Drop rails < 4.2

Code style fixes
@iainbeeston
Copy link

Another advantage of this is that bundler 2.0 is out now, which only works on ruby 2.3 and greater. The build on master is failing right now for older ruby versions, because travis is installing bundler 2.0 and then erroring out because the ruby version is incompatible.

@jopotts
Copy link
Contributor

jopotts commented May 14, 2019

@avit Thanks for all the amazing work on ice_cube over the years. I think this PR would be a good one to kickstart some updates? I'm looking for solid ruby 2.5 support so wondering the best way forwards on that?

@gssbzn gssbzn closed this Dec 19, 2019
@jopotts
Copy link
Contributor

jopotts commented Dec 19, 2019

It's a shame to see this PR closed. This gem needs some core updates to keep it working on newer rubies.

@avit & @seejohnrun is there some way you could open this up to more community maintainers?

@gssbzn
Copy link
Author

gssbzn commented Dec 19, 2019

I'm no longer actively working with this gem or Ruby in general and considering the PR was open for I decided to close it and let someone else give it a try

sebastienhoorens added a commit to CitizenLabDotCo/ice_cube that referenced this pull request Mar 6, 2020
sebastienhoorens added a commit to CitizenLabDotCo/ice_cube that referenced this pull request Mar 9, 2020
CL2-5023 Drop support for old ruby and ruby rails versions (closed PR ice-cube-ruby#459)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants