Ignore EEXIST error to fix an write after end issue

[vager]

No description provided.

[iccicci]

Hi @ccHare ,

first of all thank you for you interest in rotating-file-stream.

One question, can please you provide me an example failing without your patch?
the function makePath should be called only when the directory does not exists: I can't imagine a scenario when that function is called and directory exists.

Thank you,
iCC

[vager]

Hi @iccicci

The following is a simple example I try to reproduce write after end error,

const fs = require('fs');
const rfs = require('rotating-file-stream');
const rimraf = require('rimraf');

let path = '/tmp/logdir';
rimraf.sync(path);

let stream1 = rfs('access.log', {
    path:     path,
    rotationTime: true
});
// Failed to create log file server.log in /tmp/logdir/
let stream2 = rfs('server.log', {
    path:     path,
    rotationTime: true
});

let rs = fs.createReadStream('/tmp/64M');
rs.pipe(stream2);
rs.pipe(stream1);

My failing code(encounter write after end) is more complicated than this simple example, but their logic is similar.

Thanks

[iccicci]

You are right!

Being all processes asynchronous, can exist (as you proved) cases where two concurrent directory creation attempts happen.

Thank you,
iCC