Closed
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## version/6.0 #914 +/- ##
=============================================
+ Coverage 69.5% 69.6% +0.1%
=============================================
Files 119 119
Lines 4752 4752
Branches 1108 1108
=============================================
+ Hits 3304 3308 +4
+ Misses 1059 1055 -4
Partials 389 389
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
axunonb
reviewed
Jan 26, 2026
| .Select(x => todo.IsCompleted(x.AtMidnight().InUtc())) | ||
| .ToList(); | ||
|
|
||
| List<bool> expected = [true, true, true, true, true, true, true, true, false, false]; |
Collaborator
There was a problem hiding this comment.
// Jan 14-21: true (8 days) - TODO is considered completed
// Jan 22-23: false (2 days) - TODO is NOT completed
maknapp
force-pushed
the
maknapp/fix-todo-eval-without-end
branch
from
9b71d62 to
00c05e9
Compare
maknapp
force-pushed
the
maknapp/fix-todo-eval-without-end
branch
from
00c05e9 to
499fcdc
Compare
|
Collaborator
Author
|
This can be closed if #922 is merged because it deletes these changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a v6 fix for #913. Should probably be fixed for v5 too. I am still trying to make sense of the TODO stuff, but I think
TakeWhilewas the original intention here.