Skip to content

Implement BYDAY with offset and limiting behavior#887

Merged
axunonb merged 5 commits into
mainfrom
wip/axunonb/pr/byday-with-bymonthday-or-byyearday
Dec 23, 2025
Merged

Implement BYDAY with offset and limiting behavior#887
axunonb merged 5 commits into
mainfrom
wip/axunonb/pr/byday-with-bymonthday-or-byyearday

Implement recommendations from review

ab0dff5
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 23, 2025 in 0s

68.5% (target 67.0%)

View this Pull Request on Codecov

68.5% (target 67.0%)

Details

Codecov Report

❌ Patch coverage is 94.82759% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
Ical.Net/Evaluation/RecurrencePatternEvaluator.cs 94.6% 1 Missing and 2 partials ⚠️

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #887     +/-   ##
=======================================
+ Coverage   68.3%   68.5%   +0.2%     
=======================================
  Files        115     115             
  Lines       4376    4394     +18     
  Branches    1010    1011      +1     
=======================================
+ Hits        2988    3008     +20     
  Misses      1028    1028             
+ Partials     360     358      -2     
Files with missing lines Coverage Δ
Ical.Net/Evaluation/RecurrenceUtil.cs 100.0% <100.0%> (ø)
Ical.Net/Evaluation/RecurrencePatternEvaluator.cs 92.3% <94.6%> (+1.2%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.