-
Notifications
You must be signed in to change notification settings - Fork 247
Add wiki recurrence page #848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@NRG-Drink Sorry for the delayed reply. As time allows, I'm currently working on implementing a logger for ical.net. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my detailed comments
|
The failing unit test are caused by expecting Windows CRLF while the tests run on Ubuntu. |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #848 +/- ##
=====================================
Coverage 67.9% 67.9%
=====================================
Files 112 112
Lines 4297 4297
Branches 973 973
=====================================
+ Hits 2917 2919 +2
+ Misses 1037 1035 -2
Partials 343 343 see 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
@NRG-Drink Not sure about the state of this PR. I think the current main branch should get merged or rebased. |
* Implement remarks from last PR review * Updated class `ToLogExtensions` for better formatting of occurrences. * Introduce logging to create strings for ICS and occurrences and simplify copying to the Wiki * Added new tests for time zone changes and complex recurrence rules * Update `RecurrenceWiki.md` * Movef `RecurrenceWiki.md` to https://github.com/ical-org/ical.net/wiki/Working-with-recurring-elements
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NRG-Drink Thanks for preparing the new code samples for the Wiki.
The description can be found at https://github.com/ical-org/ical.net/wiki/Working-with-recurring-elements
Sorry for my absence on this task and thanks for finishing it. It looks pretty good in the wiki. |



I added the complete recurrence wiki page (.md) in this pr, so we can review an discuss about it but I'm not sure if this is the right way and if it should go on the main branch or not.
content:
closes #846