Skip to content

Conversation

@NRG-Drink
Copy link
Contributor

I added the complete recurrence wiki page (.md) in this pr, so we can review an discuss about it but I'm not sure if this is the right way and if it should go on the main branch or not.

content:

  • Changed the recurrence examples completely
  • Added a test for every wiki example

closes #846

@NRG-Drink NRG-Drink requested a review from axunonb July 27, 2025 17:27
@NRG-Drink NRG-Drink changed the title Pr/nrg/wiki recurrence Add Wiki Recurrence Page Aug 2, 2025
@NRG-Drink NRG-Drink changed the title Add Wiki Recurrence Page Add wiki recurrence page Aug 2, 2025
@axunonb
Copy link
Collaborator

axunonb commented Aug 6, 2025

@NRG-Drink Sorry for the delayed reply. As time allows, I'm currently working on implementing a logger for ical.net.
A logger could make creating the results for the Wiki samples a lot easier. So please let me finish the logger first.

@NRG-Drink
Copy link
Contributor Author

@NRG-Drink Sorry for the delayed reply. As time allows, I'm currently working on implementing a logger for ical.net. A logger could make creating the results for the Wiki samples a lot easier. So please let me finish the logger first.
@axunonb Thanks for the info. That's no problem :)

Copy link
Collaborator

@axunonb axunonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my detailed comments

@axunonb
Copy link
Collaborator

axunonb commented Aug 21, 2025

The failing unit test are caused by expecting Windows CRLF while the tests run on Ubuntu.
Unit tests should pass an Windows and Linux environments.

Failed DailyIntervalCountMoved [14 ms]
  Error Message:
     Assert.That(occurrenceTestString, Is.EqualTo(expectedOccurrenceDates))
  Expected string length 338 but was 345. Strings differ at index 40.
  Expected: "DTEND;TZID=Europe/Zurich:20250710T100000\nDTSTART;TZID=Europe/..."
  But was:  "DTEND;TZID=Europe/Zurich:20250710T100000\r\nDTSTART;TZID=Europe..."
  ---------------------------------------------------^

@codecov
Copy link

codecov bot commented Aug 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #848   +/-   ##
=====================================
  Coverage   67.9%   67.9%           
=====================================
  Files        112     112           
  Lines       4297    4297           
  Branches     973     973           
=====================================
+ Hits        2917    2919    +2     
+ Misses      1037    1035    -2     
  Partials     343     343           

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@axunonb
Copy link
Collaborator

axunonb commented Sep 16, 2025

@NRG-Drink Not sure about the state of this PR. I think the current main branch should get merged or rebased.
File Ical.Net.Tests/WikiSamples/RecurrenceWiki.md is still included, while it should go to the Wiki repo, right?

* Implement remarks from last PR review
* Updated class `ToLogExtensions` for better formatting of occurrences.
* Introduce logging to create strings for ICS and occurrences and simplify copying to the Wiki
* Added new tests for time zone changes and complex recurrence rules
* Update `RecurrenceWiki.md`
* Movef `RecurrenceWiki.md` to https://github.com/ical-org/ical.net/wiki/Working-with-recurring-elements
@sonarqubecloud
Copy link

@axunonb axunonb marked this pull request as ready for review September 23, 2025 09:53
@axunonb axunonb self-requested a review September 23, 2025 09:53
Copy link
Collaborator

@axunonb axunonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NRG-Drink Thanks for preparing the new code samples for the Wiki.
The description can be found at https://github.com/ical-org/ical.net/wiki/Working-with-recurring-elements

@axunonb axunonb merged commit 2c4b3c3 into main Sep 23, 2025
11 checks passed
@axunonb axunonb deleted the pr/nrg/wiki-recurrence branch September 23, 2025 09:55
@NRG-Drink
Copy link
Contributor Author

@NRG-Drink Thanks for preparing the new code samples for the Wiki. The description can be found at https://github.com/ical-org/ical.net/wiki/Working-with-recurring-elements

Sorry for my absence on this task and thanks for finishing it. It looks pretty good in the wiki.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update code samples in the Wiki for v5

3 participants