Fix GetOccurrences() not properly dealing with periodStart's TZ
#842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #842 +/- ##
=======================================
+ Coverage 67.7% 67.7% +0.1%
=======================================
Files 106 106
Lines 4226 4224 -2
Branches 952 951 -1
=======================================
+ Hits 2859 2860 +1
Misses 1038 1038
+ Partials 329 326 -3
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
Collaborator
Author
|
@ical-org/maintainers TBD
Note: The code is based on #836, so that should be merged first. Only the last two commits are specific to this PR, the rest comes from the other one. |
axunonb
previously approved these changes
Jul 15, 2025
Collaborator
Agree See also: #840 (comment) |
axunonb
reviewed
Jul 15, 2025
Ical.Net.Tests/RecurrenceTests.cs
Outdated
| var cal = new Calendar(); | ||
| cal.Events.Add(evt); | ||
|
|
||
| var firstFewOcccurrences = cal.GetOccurrences().Take(3).ToList(); |
minichma
dismissed
axunonb’s stale review
The merge-base changed after approval.
minichma
force-pushed
the
work/minichma/bugfix/periodstart_tz
branch
from
2101064 to
d20cf38
Compare
minichma
force-pushed
the
work/minichma/bugfix/periodstart_tz
branch
from
90e536a to
5ef193f
Compare
|
Collaborator
|
Ready for release 5.1.0 now? |
This was referenced Jul 28, 2025
This was referenced Aug 18, 2025
This was referenced Oct 13, 2025
This was referenced Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetOccurrences()used to ignore the TZ ofperiodStart, which is fixed by this PR.fixes #840