Skip to content

Fix: Exception for Blazor WebAssembly using FileVersionInfo #820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 19, 2025
Merged

Fix: Exception for Blazor WebAssembly using FileVersionInfo #820

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ca3826f
Fix for https://github.com/ical-org/ical.net/issues/819#issue-3156911979
b-straub Jun 19, 2025
a7d9644
Fix for https://github.com/ical-org/ical.net/issues/819#issue-3156911979
b-straub Jun 19, 2025
7e4d052
Fix for https://github.com/ical-org/ical.net/issues/819#issue-3156911979
b-straub Jun 19, 2025
c65a6ab
Fix for https://github.com/ical-org/ical.net/issues/819#issue-3156911979
b-straub Jun 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions Ical.Net/Constants.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@

using System;
using System.Diagnostics;
using System.Reflection;

namespace Ical.Net;

Expand Down Expand Up @@ -255,11 +256,8 @@ public static class LibraryMetadata
private static string GetAssemblyVersion()
{
var assembly = typeof(LibraryMetadata).Assembly;
var fileVersionInfo = FileVersionInfo.GetVersionInfo(assembly.Location);
// Prefer the file version, but fall back to the assembly version if it's not available.
return fileVersionInfo.FileVersion
?? assembly.GetName().Version?.ToString() // will only change for major versions
?? "1.0.0.0";
var fileVersionAttribute = assembly.GetCustomAttribute<AssemblyFileVersionAttribute>();
return fileVersionAttribute?.Version ?? assembly.GetName().Version?.ToString() ?? "1.0.0.0";
}
}

Expand Down
Loading