Skip to content

Fix: Exception for Blazor WebAssembly using FileVersionInfo #820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 19, 2025
Merged

Fix: Exception for Blazor WebAssembly using FileVersionInfo #820

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ca3826f
Fix for https://github.com/ical-org/ical.net/issues/819#issue-3156911979
b-straub Jun 19, 2025
a7d9644
Fix for https://github.com/ical-org/ical.net/issues/819#issue-3156911979
b-straub Jun 19, 2025
7e4d052
Fix for https://github.com/ical-org/ical.net/issues/819#issue-3156911979
b-straub Jun 19, 2025
c65a6ab
Fix for https://github.com/ical-org/ical.net/issues/819#issue-3156911979
b-straub Jun 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions Ical.Net/Constants.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,12 +254,21 @@ public static class LibraryMetadata

private static string GetAssemblyVersion()
{
string? version;
var assembly = typeof(LibraryMetadata).Assembly;
var fileVersionInfo = FileVersionInfo.GetVersionInfo(assembly.Location);

// Prefer the file version, but fall back to the assembly version if it's not available.
return fileVersionInfo.FileVersion
?? assembly.GetName().Version?.ToString() // will only change for major versions
?? "1.0.0.0";
try
Copy link
Collaborator

@axunonb axunonb Jun 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code introduced in this GitHub comment doesn't work for WebAssembly? The advantage was that we wouldn't need the try/catch. In both cases, caching the value would be advantageous.

Copy link
Contributor Author

@b-straub b-straub Jun 19, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, was too fast with my fix. Working indeed, so you can throw away the pull request and replace with the suggested code.

{
var fileVersionInfo = FileVersionInfo.GetVersionInfo(assembly.Location);
version = fileVersionInfo.FileVersion;
}
catch (Exception)
{
version = assembly.GetName().Version?.ToString();
}

return version ?? "2.0";
Copy link
Collaborator

@axunonb axunonb Jun 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see below regarding "2.0"

}
}

Expand Down
1 change: 1 addition & 0 deletions Ical.Net/Ical.Net.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
<AssemblyOriginatorKeyFile>..\IcalNetStrongnameKey.snk</AssemblyOriginatorKeyFile>
<nullable>enable</nullable>
<LangVersion>latest</LangVersion>
<AssemblyVersion>2.0</AssemblyVersion>
Copy link
Collaborator

@axunonb axunonb Jun 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All version attributes get set during publishing with the CI workflow.
Mixing up 2.0 with the iCalendar version defined in RFC 5545 Section 3.7.4?

Copy link
Contributor Author

@b-straub b-straub Jun 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood. Anyway obsolete see comment above.

</PropertyGroup>
<ItemGroup>
<PackageReference Include="NodaTime" Version="3.2.2" />
Expand Down
Loading