Determine Occurrence.Period by Duration only
#808
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axunonb
force-pushed
the
pr/use-duration-for-occurrence-periods
branch
2 times, most recently
from
d2e271f to
35c3693
Compare
* Update `EventEvaluator` * `Period`: Trying to create a `Period` a using a date-only `CalDateTime` and `Duration.HasTime` will throw * Modify `.ics` files of unit tests to either contain `DTEND` or `DURATION` (never both) to get unambiguous test results * Modifty unit tests to use `Period.EffectiveEndTime` instead of `Period.EndTime` * Add unit test for issue ical-org#737 Resolves ical-org#737
axunonb
force-pushed
the
pr/use-duration-for-occurrence-periods
branch
from
35c3693 to
e587ce8
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors how event Periods are determined by relying solely on durations, adds validation to prevent mixing date-only starts with time-based durations, and updates tests/fixtures for unambiguous results.
- Update
RecurrenceUtilto filter onEffectiveEndTimeinstead of a nullableEndTimefallback - Rewrite
EventEvaluatorto create periods fromDurationonly (WithFinalDuration), and enforce representable end times - Add a check in
Periodconstructor to forbid adding a time-based duration to a date-only start - Adjust test assertions to use
EffectiveEndTime, remove ambiguous.icsfixtures, and add a new test for issue #737
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Ical.Net/Evaluation/RecurrenceUtil.cs | Use EffectiveEndTime for occurrence filtering |
| Ical.Net/Evaluation/EventEvaluator.cs | Replace WithEndTime with WithFinalDuration and duration‐based logic |
| Ical.Net/DataTypes/Period.cs | Prevent adding time-based durations to date-only starts |
| Ical.Net.Tests/* | Updated assertions to EffectiveEndTime, adjusted .ics fixtures, added new DST test |
Comments suppressed due to low confidence (2)
Ical.Net/Evaluation/EventEvaluator.cs:52
- Update the XML documentation to reflect that
WithFinalDurationuses the period'sDurationandEffectiveEndTimerather than settingEndTimedirectly.
/// <param name="period">The period where <see cref="Period.EndTime"/> will be set.</param>
Ical.Net/Evaluation/RecurrenceUtil.cs:39
- [nitpick] Rename the local variable
endTimetoeffectiveEndTimeto clearly indicate it refers toEffectiveEndTimeand avoid confusion with the originalEndTimeproperty.
let endTime = p.EffectiveEndTime
Co-authored-by: Copilot <[email protected]>
axunonb
force-pushed
the
pr/use-duration-for-occurrence-periods
branch
from
741371d to
054a8e6
Compare
…RangeException` This exception is more accurate than System.ArgumentOutOfRangeException
axunonb
force-pushed
the
pr/use-duration-for-occurrence-periods
branch
from
054a8e6 to
8672357
Compare
|
This was referenced Jul 28, 2025
This was referenced Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EventEvaluatorto use the start time withDurationinstead of end time to create aPeriodforOccurrencePeriod: Trying to create aPeriodby using a date-onlyCalDateTimeandDuration.HasTimewill throw.icsfiles of unit tests to either containDTENDorDURATION(never both) to get unambiguous test resultsPeriod.EffectiveEndTimeinstead ofPeriod.EndTimeResolves #737