Skip to content

Conversation

@NRG-Drink
Copy link
Contributor

It's allowed to have CATEGORIES property multiple times in an event but it's not that pretty and some other programs will have trouble reading such events. So it's more a feature than a bug (#156).
Here is a quick fix to display multiple categories in one line.

@axunonb
Copy link
Collaborator

axunonb commented May 19, 2025

Thanks, very good! See comments if your time allows.

@sonarqubecloud
Copy link

@axunonb axunonb self-requested a review May 19, 2025 08:50
Copy link
Collaborator

@axunonb axunonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was fast, great! Thanks for your support.
Would you like to join the ical.net party?

@axunonb axunonb merged commit a468230 into ical-org:main May 19, 2025
4 checks passed
@axunonb axunonb changed the title feat: serialize multiple categories to oneline feat: Serialize multiple categories and resources to one line May 19, 2025
@NRG-Drink
Copy link
Contributor Author

That was fast, great! Thanks for your support. Would you like to join the ical.net party?

You were even faster. I wasn't done and there is an error in the test 😅
btw. is it possible that ATTENDEE is broken? I tried to enable oneline for attendees too but it only performs a ToString on it and not serializing it properly. I think I will leave it for the moment.

@NRG-Drink
Copy link
Contributor Author

That was fast, great! Thanks for your support. Would you like to join the ical.net party?

I can try to help out on smaller tasks if it helps 😊

@axunonb
Copy link
Collaborator

axunonb commented May 19, 2025

btw. is it possible that ATTENDEE is broken? I tried to enable oneline for attendees

Attendee requires its own AttendeeSerializer, as it's more complex than e.g. CATEGORIES. That's why.

You were even faster.

Should have awaited your review request, right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants