Enable CA1305 warnings and fix them

[axunonb]

• Add package Microsoft.CodeAnalysis.NetAnalyzers (for build only)
• Add dotnet_diagnostic.CA1305.severity = warning to .editorconfig
• Fix CA1305 warning or disable with pragma where appropriate
• Add unit test as proposed in issue

Resolves #792

[codecov]

Codecov Report

Attention: Patch coverage is 90.62500% with 3 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
....Net/Serialization/DataTypes/DurationSerializer.cs	83%	1 Missing ⚠️
...l.Net/Serialization/DataTypes/IntegerSerializer.cs	67%	1 Missing ⚠️
...et/Serialization/DataTypes/StatusCodeSerializer.cs	0%	1 Missing ⚠️

❌ Your project status has failed because the head coverage (67%) is below the target coverage (80%). You can increase the head coverage or adjust the target coverage.

@@         Coverage Diff         @@
##           main   #794   +/-   ##
===================================
  Coverage    67%    67%           
===================================
  Files       105    105           
  Lines      4414   4419    +5     
  Branches   1060   1060           
===================================
+ Hits       2936   2940    +4     
- Misses     1044   1045    +1     
  Partials    434    434           

Files with missing lines	Coverage Δ
Ical.Net/DataTypes/GeographicLocation.cs	50% <100%> (ø)
Ical.Net/DataTypes/UTCOffset.cs	64% <100%> (+5%)	⬆️
....Net/Serialization/DataTypes/DateTimeSerializer.cs	85% <100%> (ø)
...alization/DataTypes/RecurrencePatternSerializer.cs	93% <100%> (ø)
...Net/Serialization/DataTypes/UtcOffsetSerializer.cs	65% <100%> (+2%)	⬆️
...l.Net/Serialization/DataTypes/WeekDaySerializer.cs	61% <100%> (ø)
....Net/Serialization/DataTypes/DurationSerializer.cs	86% <83%> (ø)
...l.Net/Serialization/DataTypes/IntegerSerializer.cs	57% <67%> (ø)
...et/Serialization/DataTypes/StatusCodeSerializer.cs	46% <0%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[minichma]

Wow, this was fast. Just a note on string interpolation. In a work project we have some utility method like the following:

        public static string Invariant(IFormattable v)
            => (v == null) ? null : v.ToString(null, CultureInfo.InvariantCulture);

This can be used to make string interpolation culture invariant like so:

Invariant($"{...}")

Maybe an option instead of the pragmas.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[axunonb]

public static string Invariant(IFormattable v)
=> (v == null) ? null : v.ToString(null, CultureInfo.InvariantCulture);

Thanks for the hint.

We can also use the built-in FormattableString.Invariant e.g.

sb.Append(FormattableString.Invariant($"{sign * (ts.Hours)}H"));

directly. I was not aware of that.

Here the compiler automatically creates a FormattableString object instead of a string under the hood

FormattableString fs = $"{sign * (ts.Hours ?? 0)}H";
sb.Append(FormattableString.Invariant(fs));

From NET6.0 the right way seems to be (according to SonarCloud)
string.Create(CultureInfo.InvariantCulture, $"{sign * (ts.Hours)}H"); with less memory allocation
which unfortunately is not supported in netstandard2.x

[minichma]

Very nice and good to know, haven't been aware of that either.