-
Notifications
You must be signed in to change notification settings - Fork 247
Remove unnecessary GroupedListEnumerator
#793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ❌ Your project status has failed because the head coverage (67%) is below the target coverage (80%). You can increase the head coverage or adjust the target coverage. @@ Coverage Diff @@
## main #793 +/- ##
===================================
- Coverage 67% 67% -0%
===================================
Files 106 105 -1
Lines 4450 4414 -36
Branches 1072 1060 -12
===================================
- Hits 2965 2936 -29
+ Misses 1046 1044 -2
+ Partials 439 434 -5
🚀 New features to boost your workflow:
|
Absolutely. But do we need this at all? The only usage I can find is here: ical.net/Ical.Net/Collections/GroupedList.cs Line 221 in c7fd686
Couldn't we just implement that like so? _lists.SelectMany(x => x).GetEnumerator(); |
0fa7818 to
44a3eb1
Compare
|
This kind of simplification really goes way to far 😂 |
GroupedListEnumeratorGroupedListEnumerator
minichma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it!



This also simplified the code IMHO.