Skip to content

Conversation

@axunonb
Copy link
Collaborator

@axunonb axunonb commented May 7, 2025

  • Auto-replace #nullable enable per file with empty string
  • Add nullable setting for all project files (Ical.Net: enable, Ical.Net.Tests: disable)
  • Update GitHub Workflows nullability parameter: Now uses project settings
  • Migrate Ical.Net.Benchmarks to NRT enabled

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 7, 2025

@axunonb axunonb marked this pull request as ready for review May 7, 2025 22:17
@axunonb axunonb requested a review from minichma May 7, 2025 22:17
@axunonb
Copy link
Collaborator Author

axunonb commented May 7, 2025

Couldn't yet find a way to get rid of the nullability warnings for netstandard2.0 on ubuntu. They don't appear on Windows.

Copy link
Collaborator

@minichma minichma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats, with all the previous NRT PRs this was a significant piece work. Thanks for the nice commit structure of this one, made the review a breeze.

@axunonb
Copy link
Collaborator Author

axunonb commented May 8, 2025

Thanks for the review. The NRT for the ical.net project is finally completed. Implementing NRT for the unit tests is less painful, and we can handle it one file at a time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants