RecurrencePatternEvaluator: Modernize some evaluation code. #783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… pattern evaluation by making more use of the generator pattern.
Codecov ReportAttention: Patch coverage is
❌ Your project status has failed because the head coverage (66%) is below the target coverage (80%). You can increase the head coverage or adjust the target coverage. @@ Coverage Diff @@
## main #783 +/- ##
===================================
- Coverage 66% 66% -0%
===================================
Files 104 105 +1
Lines 4495 4438 -57
Branches 1140 1115 -25
===================================
- Hits 2969 2912 -57
- Misses 1061 1062 +1
+ Partials 465 464 -1
🚀 New features to boost your workflow:
|
minichma
force-pushed
the
work/minichma/feature/eval_generator_improvements
branch
from
f257d4e to
8869f89
Compare
minichma
force-pushed
the
work/minichma/feature/eval_generator_improvements
branch
from
8869f89 to
38727d8
Compare
|
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the evaluation code in RecurrencePatternEvaluator by simplifying code patterns and reducing complexity. The changes improve clarity and reduce unnecessary code branches.
- Removed unneeded
.ToList()calls in favor of generator-based patterns - Refactored methods using LINQ and separated complex logic into simpler static methods
axunonb
reviewed
May 6, 2025
| if (r.ByHour?.Count > 0) r.ByHour = r.ByHour.OrderBy(x => x).ToList(); | ||
| if (r.ByMonth?.Count > 0) r.ByMonth = r.ByMonth.OrderBy(x => x).ToList(); | ||
|
|
||
| return r; |
axunonb
reviewed
May 6, 2025
|
|
||
| foreach (var d in monthDayDates) | ||
| yield return d; | ||
| } |
|
Thanks for the review! |
This was referenced Jul 28, 2025
This was referenced Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modernize some code in
RecurrencePatternEvaluator, including.ToList()in favor of simpler generator based patternsAs a result the code gets simpler, more readable and we achieve the same functionality with less code and execution branches.