EvaluationOptions: Fix off-by-one issue of MaxUnmatchedIncrementsLimit
#775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ ❌ Your project status has failed because the head coverage (67%) is below the target coverage (80%). You can increase the head coverage or adjust the target coverage. @@ Coverage Diff @@
## main #775 +/- ##
===================================
Coverage 67% 67%
===================================
Files 104 104
Lines 4490 4490
Branches 1111 1111
===================================
Hits 2998 2998
Misses 1064 1064
Partials 428 428
🚀 New features to boost your workflow:
|
minichma
force-pushed
the
work/minichma/bugfix/evaloptions_offbyone
branch
from
783833a to
6532cca
Compare
|
minichma
changed the title
MaxUnmatchedIncrementsLimitMaxUnmatchedIncrementsLimit
axunonb
reviewed
Apr 24, 2025
This was referenced Jul 28, 2025
This was referenced Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The evaluation of
EvaluationOptions.MaxUnmatchedIncrementsLimitis off by one, which is fixed by this PR.