-
Notifications
You must be signed in to change notification settings - Fork 247
Enable NRT for Collections and Proxies namespace
#769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is ❌ Your patch status has failed because the patch coverage (39%) is below the target coverage (80%). You can increase the patch coverage or adjust the target coverage. @@ Coverage Diff @@
## main #769 +/- ##
===================================
Coverage 67% 67%
===================================
Files 104 104
Lines 4499 4490 -9
Branches 1113 1111 -2
===================================
- Hits 3003 2998 -5
+ Misses 1066 1064 -2
+ Partials 430 428 -2
🚀 New features to boost your workflow:
|
11d6999 to
e65c7aa
Compare
Collections namespaceCollections and Proxies namespace
e65c7aa to
cf7a522
Compare
Including necessary NRT updates to * CalendarComponents * Alarm * CalendardEvent * FreeBusy * Journal * Todo * VTimeZone * Interfaces.IValueObject * Proxies.GroupedCollectionProxy * Proxies.GroupedValueListProxy * DataTypes.CalendarDataType * Evaluation.TodoEvaluator * Proxies * CalendarObjectListProxy * IUniqueComponentList * UniqueComponentListProxy * ParameterCollectionProxy * CalendarParameter * CalendarProperty * VTimeZoneInfo * some unit tests
cf7a522 to
53b2515
Compare
|



Including necessary NRT updates to
The transition to NRT in this pull request required significant effort, particularly due to challenges with the
Collectionsnamespace and the handling ofProxies. These areas demanded careful adjustments to ensure compatibility, also given the low unit test coverage.@minichma Due to vacation I'll merge the PR, so that I can move on with NRT over the next days. Reviews and necessary corrections could then be done after the NRT transition is completed.