Skip to content

Conversation

@axunonb
Copy link
Collaborator

@axunonb axunonb commented Apr 13, 2025

Including necessary NRT updates to

  • CalendarComponents
    • Alarm
    • CalendardEvent
    • FreeBusy
    • Journal
    • Todo
    • VTimeZone
    • Interfaces.IValueObject
    • Proxies.GroupedCollectionProxy
    • Proxies.GroupedValueListProxy
  • DataTypes.CalendarDataType
  • Evaluation.TodoEvaluator
  • Proxies
    • CalendarObjectListProxy
    • IUniqueComponentList
    • UniqueComponentListProxy
    • ParameterCollectionProxy
  • CalendarParameter
  • CalendarProperty
  • VTimeZoneInfo
  • some unit tests

The transition to NRT in this pull request required significant effort, particularly due to challenges with the Collections namespace and the handling of Proxies. These areas demanded careful adjustments to ensure compatibility, also given the low unit test coverage.

@minichma Due to vacation I'll merge the PR, so that I can move on with NRT over the next days. Reviews and necessary corrections could then be done after the NRT transition is completed.

@codecov
Copy link

codecov bot commented Apr 13, 2025

Codecov Report

Attention: Patch coverage is 39.02439% with 75 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
Ical.Net/Collections/GroupedList.cs 34% 22 Missing and 5 partials ⚠️
...l.Net/Collections/Proxies/GroupedValueListProxy.cs 36% 14 Missing and 2 partials ⚠️
Ical.Net/Proxies/UniqueComponentListProxy.cs 0% 6 Missing and 1 partial ⚠️
Ical.Net/CalendarParameter.cs 55% 5 Missing ⚠️
Ical.Net/Proxies/ParameterCollectionProxy.cs 17% 5 Missing ⚠️
....Net/Collections/Proxies/GroupedCollectionProxy.cs 57% 3 Missing ⚠️
Ical.Net/CalendarComponents/Alarm.cs 0% 2 Missing ⚠️
Ical.Net/Collections/GroupedListEnumerator.cs 60% 0 Missing and 2 partials ⚠️
Ical.Net/Evaluation/TodoEvaluator.cs 33% 1 Missing and 1 partial ⚠️
Ical.Net/VTimeZoneInfo.cs 0% 2 Missing ⚠️
... and 4 more

❌ Your patch status has failed because the patch coverage (39%) is below the target coverage (80%). You can increase the patch coverage or adjust the target coverage.
❌ Your project status has failed because the head coverage (67%) is below the target coverage (80%). You can increase the head coverage or adjust the target coverage.

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #769   +/-   ##
===================================
  Coverage    67%    67%           
===================================
  Files       104    104           
  Lines      4499   4490    -9     
  Branches   1113   1111    -2     
===================================
- Hits       3003   2998    -5     
+ Misses     1066   1064    -2     
+ Partials    430    428    -2     
Files with missing lines Coverage Δ
Ical.Net/CalendarComponents/FreeBusy.cs 48% <ø> (ø)
Ical.Net/CalendarComponents/Journal.cs 53% <ø> (ø)
Ical.Net/CalendarComponents/Todo.cs 66% <ø> (ø)
Ical.Net/CalendarProperty.cs 53% <100%> (-1%) ⬇️
Ical.Net/Collections/GroupedValueList.cs 89% <100%> (ø)
Ical.Net/Collections/ObjectEventArgs.cs 100% <ø> (ø)
Ical.Net/DataTypes/CalendarDataType.cs 48% <100%> (-1%) ⬇️
Ical.Net/CalendarComponents/CalendarEvent.cs 75% <83%> (+4%) ⬆️
Ical.Net/CalendarComponents/VTimeZone.cs 72% <50%> (-<1%) ⬇️
Ical.Net/Collections/MultiLinkedList.cs 0% <0%> (ø)
... and 11 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@axunonb axunonb force-pushed the axunonb/wip/pr/nrt-calendar-proxies-collections branch 3 times, most recently from 11d6999 to e65c7aa Compare April 13, 2025 08:40
@axunonb axunonb changed the title Enable NRT for Collections namespace Enable NRT for Collections and Proxies namespace Apr 13, 2025
@axunonb axunonb marked this pull request as ready for review April 13, 2025 08:59
@axunonb axunonb force-pushed the axunonb/wip/pr/nrt-calendar-proxies-collections branch from e65c7aa to cf7a522 Compare April 13, 2025 12:06
Including necessary NRT updates to
* CalendarComponents
   * Alarm
   * CalendardEvent
   * FreeBusy
   * Journal
   * Todo
   * VTimeZone
   * Interfaces.IValueObject
   * Proxies.GroupedCollectionProxy
   * Proxies.GroupedValueListProxy
* DataTypes.CalendarDataType
* Evaluation.TodoEvaluator
* Proxies
   * CalendarObjectListProxy
   * IUniqueComponentList
   * UniqueComponentListProxy
   * ParameterCollectionProxy
* CalendarParameter
* CalendarProperty
* VTimeZoneInfo
* some unit tests
@axunonb axunonb force-pushed the axunonb/wip/pr/nrt-calendar-proxies-collections branch from cf7a522 to 53b2515 Compare April 13, 2025 12:46
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants