-
Notifications
You must be signed in to change notification settings - Fork 247
Change DateTime method args to CalDateTime
#761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ction` Make `EvaluationOptions` nullable - `CalendarCollection`: Remove `GetOccurrences` overloads using `DaTime` - `Calendar`: Remove `GetOccurrences` overloads using `DaTime` - `IGetOccurrences`: enable NRT - `IGetOccurrences`: enable NRT - Modified `GetOccurrences` method signatures to accept nullable `CalDateTime` and `EvaluationOptions` - Adjusted `Evaluate` methods to handle nullable `EvaluationOptions`. - Updated `Alarm` class methods to utilize nullable options.
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (40%) is below the target coverage (80%). You can increase the patch coverage or adjust the target coverage. @@ Coverage Diff @@
## main #761 +/- ##
===================================
Coverage 67% 67%
===================================
Files 104 104
Lines 4517 4508 -9
Branches 1106 1103 -3
===================================
Hits 3012 3012
+ Misses 1072 1065 -7
+ Partials 433 431 -2
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
8c9d01b to
36d505a
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
Ical.Net/VTimeZoneInfo.cs:100
- [nitpick] When a null value is assigned to TimeZoneName, an empty string is added instead. Consider whether this behavior aligns with the intended design or if null should clear the list instead.
TimeZoneNames.Add(value ?? string.Empty);
minichma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great. As so often - the best code is deleted code.
| { | ||
| TimeZoneNames.Clear(); | ||
| TimeZoneNames.Add(value); | ||
| TimeZoneNames.Add(value ?? string.Empty); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the getter, null would represent an empty list rather than a list with an empty string as its sole member.



Methods left using
DateTime:Closes #703