-
Notifications
You must be signed in to change notification settings - Fork 247
Fix when no "SENT-BY" defined, get SentBy will throw exception #669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for submitting the PR. The
@minichma What do you think. Should we fix this issue in an isolated or a "fix it all" context? |
|
I agree. This PR certainly is beneficial, but the same improvement as for @idiotsky Would you be ready to adjust the PR accordingly? Generally speaking, I think that representing these values as |
I agree with replace the Uri to string is better idea. |
Nullable reference types were enabled in the `Organizer` class, ensuring properties like `SentBy`, `DirectoryEntry`, and `Value` handle nullability appropriately. A new `Journal3` ICS file and its associated test were added to validate `SENT-BY` behavior in journals.
|
|
I submit the changes, any feed back, I'll try to fix it. |
minichma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@idiotsky Thank you! |
you are welcome |
|
Closes #587 |



No description provided.