Skip to content

Conversation

@minichma
Copy link
Collaborator

Remove remaining usages of MinValue and clean up related code, i.e.

  • Replace usage of DateTime.MinValue in RecurrencePatternEvaluator.
  • Simplify RecurrencePatternSerializer.CheckMutuallyExclusive to avoid using reflection and checking for MinValue

@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...alization/DataTypes/RecurrencePatternSerializer.cs 0% 0 Missing and 1 partial ⚠️

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #668   +/-   ##
===================================
  Coverage    63%    63%           
===================================
  Files        99     99           
  Lines      4594   4586    -8     
  Branches   1085   1083    -2     
===================================
  Hits       2877   2877           
+ Misses     1258   1251    -7     
+ Partials    459    458    -1     
Files with missing lines Coverage Δ
Ical.Net/Evaluation/RecurrencePatternEvaluator.cs 71% <100%> (ø)
...alization/DataTypes/RecurrencePatternSerializer.cs 70% <0%> (+2%) ⬆️

@minichma minichma marked this pull request as ready for review December 10, 2024 16:56
@minichma minichma requested a review from axunonb December 10, 2024 16:56
Copy link
Collaborator

@axunonb axunonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the missing parts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants