Recurrence: Reproduce and fix issues if BYWEEKNO and INTERVAL are used together
#657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and `DTSTART`'s week belongs to a different year than the date's year.
|
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #657 +/- ##
===================================
Coverage 60% 60%
===================================
Files 100 100
Lines 4657 4661 +4
Branches 1106 1109 +3
===================================
+ Hits 2811 2815 +4
Misses 1379 1379
Partials 467 467
|
axunonb
reviewed
Nov 30, 2024
axunonb
approved these changes
Nov 30, 2024
Collaborator
axunonb
left a comment
axunonb
left a comment
There was a problem hiding this comment.
Really good, recurrence quality is increasing! Tnx
This was referenced Jul 28, 2025
This was referenced Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reproduces and fixes more issues around
BYWEEKNO, in particular if used together withINTERVALand ifDTSTARTlies in a different year then the week it lies in. E.g.20100102T000000is in 2010, but the week number is 53 of 2009. In such cases the lib increments year invervals staring from 2010 rather than from 2009, which is wrong.