RRULE Evaluation: Apply BYYEARDAY=366 only in leap years.
#621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axunonb
reviewed
Oct 22, 2024
axunonb
reviewed
Oct 22, 2024
minichma
force-pushed
the
bugfix/rrule_byday_366
branch
from
8f70269 to
c4f1888
Compare
|
Collaborator
Author
|
@axunonb I think you need to approve again. Thanks! |
This was referenced Jul 28, 2025
This was referenced Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for the following cases of #618:
RRULE:FREQ=YEARLY;BYYEARDAY=-366;COUNT=3RRULE:FREQ=YEARLY;BYYEARDAY=366;COUNT=3I.e.
BYYEARDAY=366should only exist if day 366 (or -366) exists, which is only the case in leap years.