Define behavior for time-based FREQ and date-only DTSTART #616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axunonb
reviewed
Oct 20, 2024
minichma
commented
Oct 20, 2024
… Now, after repairing it, the test fails.
… component (sec,min,hour) while DTSTART is date-only. This is undefined by RFC 5545 but we handle it by pretending DTSTART had a time set to midnight.
minichma
force-pushed
the
bugfix/evaluate1
branch
from
d95012f to
73c0b04
Compare
|
axunonb
approved these changes
Oct 20, 2024
This was referenced Jul 28, 2025
This was referenced Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #602.
Implement defined behavior of recurrence evaluation in case of a time-based FREQ (sec/min/hour) and a DTSTART of type DATE (i.e. date-only). With this PR such scenarios are handled as if DTSTART had a time set to midnight.
The case was previously covered by test
Evaluate1, which was broken and is fixed with this PR.