Checking obj2 with MinValue of type obj2, not type obj1. #470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used to check obj2 against MinValue of obj1.
minichma
approved these changes
Dec 7, 2024
Collaborator
|
Thank your and I apologize in the project's name for the delay. The project is more vital these days. Would you rebase that? Or alternatively give me Push permission? |
axunonb
approved these changes
Dec 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this code error while searching for an other bug.
It currently checks the value of obj2 against the MinValue of obj1.
var fi2 = t1.GetField("MinValue");doesn't look like it should be that way. I fixed this by checking against a new t2.