Repository navigation
fix: VTimeZone.FromSystemTimeZone for southern-hemisphere time zones - #1013
Merged
Merged
Conversation
Implementation as suggested by @daywalker7911 Resolves #1006
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #1013 +/- ##
=====================================
Coverage 72.2% 72.3%
=====================================
Files 137 137
Lines 6138 6139 +1
Branches 1434 1434
=====================================
+ Hits 4434 4437 +3
+ Misses 1246 1244 -2
Partials 458 458
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
maknapp
reviewed
Oct 18, 2026
| return; | ||
| } | ||
|
|
||
| var tz = VTimeZone.FromSystemTimeZone(tzInfo, new DateTime(2024, 1, 1), false); |
Collaborator
There was a problem hiding this comment.
Could use VTimeZone.FromDateTimeZone(tzId, ...) directly. Both methods just use the TZID to get the NodaTime time zone anyway.
Collaborator
|
The test method name still says "serialize" |
|
maknapp
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation as suggested by @daywalker7911
Resolves #1006