-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update linkextractor.rb for live logs. #13
Open
thunt-career
wants to merge
26
commits into
ibnesayeed:step6
Choose a base branch
from
thunt-career:step6
base: step6
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix plurality
Play-with-docker reference is added and organized the references.
Co-Authored-By: avinashdesireddy <[email protected]>
Update primary README of the master branch
…atest (2.7) version.
Master/Step6 Ruby version patch
Improve documentation wordings
Signed-off-by: Travis Hunt <[email protected]>
Signed-off-by: Travis Hunt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a feature pull request to update the linkextractor.rb to handle the extraction.log file so that the log can be viewed and followed while the container is running. Sending PRs to master branch and PWD repository as well.
When running through the tutorial, I was confused why the logs weren't showing anything while submitting different URLs for extraction.