Update the tomcat version to latest.#105
Merged
Merged
Conversation
AdamBrousseau
suggested changes
Apr 29, 2024
AdamBrousseau
left a comment
AdamBrousseau
left a comment
There was a problem hiding this comment.
Change looks good to me. I think you've missed 6 Dockerfiles in the 8 folder though.
Author
|
@AdamBrousseau Thank you for catching that oversight, Updated the missing files and committed the changes. |
AdamBrousseau
approved these changes
Apr 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tomcat version used in semeru containers was updated and need to change from https://dlcdn.apache.org/tomcat/tomcat-9/v9.0.85/bin/apache-tomcat-9.0.85.tar.gz to https://dlcdn.apache.org/tomcat/tomcat-9/v9.0.88/bin/apache-tomcat-9.0.88.tar.gz .
Failed build with tomcat issue : https://hyc-runtimes-jenkins.swg-devops.com/job/Semeru_ICR/216/
In this PR modified docker files to pick the latest available tomcat always.
Passing build with modified changes : https://hyc-runtimes-jenkins.swg-devops.com/job/Semeru_ICR/224
Old git issue regarding tomcat changes: https://github.ibm.com/runtimes/infrastructure/issues/8523#issuecomment-69052774