Skip to content
This repository has been archived by the owner on Oct 16, 2021. It is now read-only.

test: Fix test-cluster-worker-exit.js for AIX #54

Closed
wants to merge 1 commit into from
Closed

test: Fix test-cluster-worker-exit.js for AIX #54

wants to merge 1 commit into from

Commits on Nov 16, 2015

  1. test: Fix test-cluster-worker-exit.js for AIX

    test fails intermittently due to the assertion that the 'disconnect'
    event should come before the 'exit' event. This is caused be the
    non-deteministic behaviour of pollset_poll[1] on AIX
    (see deps/uv/src/unix/aix.c). This API makes no garauntee for the order
    in which file descriptors are returned. On linux epoll_wait[2] is used,
    which also does not make a garauntee on order of file descriptors
    returned. In the failing case we recieve our file descriptor with a
    callback of uv__signal_event (which causes JavaScript to receive the
    exit event) before our file descriptor with uv__stream_io as its
    callback (which in turn causes JavaScript receive the disconnect event).
    This change simply removes the assertion that the disconnect event
    happens before exit event and processes the test regardless of which
    event comes first.
    
    [1] https://www-01.ibm.com/support/knowledgecenter/ssw_aix_71/com.ibm.ai
    x.basetrf1/pollset.htm
    [2] http://linux.die.net/man/2/epoll_pwait
    
    PR-URL: nodejs/node#3666
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Imran Iqbal committed Nov 16, 2015
    Configuration menu
    Copy the full SHA
    58d6b4c View commit details
    Browse the repository at this point in the history