-
Notifications
You must be signed in to change notification settings - Fork 24
Conversation
Added some specific comments to the PR
In particular: We add the platoform to
Use that to generate the config file and put them in the right places in the tree (something like make linux-ppc, make linux-ppc64)
Update deps/openssl/config/opensslconf.h to pull in the new header files
that I don't see in your PR
|
74dcf5d
to
e089db0
Compare
Updated commits based on review comments. I'd previously missed an array in configure of valid arch values (for --dest-cpu) and have corrected. re 2) changes to tools/test.py and tools/utils.py I have made changes in line with what was changed for PowerPC. |
f1945a8
to
7b3a4bf
Compare
re 3) I'm not aware of any changes related to zLinux for building native modules -- Those changes were AIX specific. |
I'm pretty sure one change in particular is required. It copies the common.gypi from the runtime to the directory where the headers are expanded. This will be required because there are changes to the common.gypi (in the patches for zLinux) so without this step native modules will fail to compile. That part is not guarded for AIX. I wondered why we needed it, and we no longer need it for AIX because the changes for PPC in common.gypi are in the community but I believe we must have it for zLinux/native modules. |
Ah okay, that makes sense. As the changes are at the moment we'd only need the change for s390 (31-bit) as that's the only change in common.gypi that is required (to pass the "-m31" compiler flag through to gcc). 64-bit gcc defaults to -m64, so natives module for s390x should compile without npm changes. |
Added commit to add basic Linux s390/s390x support to deps/openssl 1). As per nodejs/node#2124 (comment) the commit initially enables openssl for s390/s390x without ASM support. |
dc084e7
to
8105f47
Compare
Updated:
|
98d398b
to
d031f2c
Compare
Rebased onto current v4.x-port branch. |
at tag export-4.5-to-node-2015-10-05
Since deps/v8 doesn't currently support s390/s390x, pick up deps/v8z instead.
d031f2c
to
0e880ed
Compare
Ported the following V8 backports/cherry-picks onto deps/v8z: 925b29f deps: backport f782159 from v8's upstream |
[WIP] Add s390/s390x Linux support
Add support for Linux on s390/s390x to Node v4. Since the base V8 doesn't yet support s390/s390x, add an equivalent to deps/v8z and use that when building.
npm test changesNo longer required after rebasechanges to enable compilation of native modulesNo longer required after rebase