vpd-tool take keyword value from file #502
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit only enables user to choose write keyword in vpd-tool
application but actual implementation of write keyword is not added.
Result:
‘’’
root@rain104bmctest:/tmp# ./vpd-tool
VPD Command Line Tool
Usage: ./vpd-tool [OPTIONS]
Options:
-h,--help Print this help message and exit
-O,--object TEXT File path
-R,--record TEXT Record name
-K,--keyword TEXT Keyword name
--file TEXT Absolute file path
-V,--value TEXT Keyword value in ascii/hex format. ascii ex: 01234; hex ex: 0x30313233
-H,--Hardware CAUTION: Developer only option.
-r,--readKeyword Needs: --object --record --keyword
Read keyword
-w,--writeKeyword Needs: --object --record --keyword
Write keyword, Note: Irrespective of dbus or hardware path provided, both DBus and hardware paths will get updated with given key value
Read:
IPZ Format:
From dbus to console: vpd-tool -r -O <DBus Object Path> -R <Record Name> -K <Keyword Name>
From dbus to file: vpd-tool -r -O <DBus Object Path> -R <Record Name> -K <Keyword Name> --file <File Path>
From hardware to console: vpd-tool -r -H -O <EEPROM Path> -R <Record Name> -K <Keyword Name>
From hardware to file: vpd-tool -r -H -O <EEPROM Path> -R <Record Name> -K <Keyword Name> --file <File Path>
Write:
IPZ Format:
On dbus: vpd-tool -w -O <DBus Object Path> -R <Record Name> -K <Keyword Name> -V <Keyword Value>
On dbus, Take keyword value from file:
vpd-tool -w -O <DBus Object Path> -R <Record Name> -K <Keyword Name> --file <File Path>
On hardware: vpd-tool -w -H -O <EEPROM Path> -R <Record Name> -K <Keyword Name> -V <Keyword Value>
On hardware, Take keyword value from file:
vpd-tool -w -H -O <EEPROM Path> -R <Record Name> -K <Keyword Name> --file <File Path>
'''
Signed-off-by: Anupama B R <[email protected]>
This commit implements VpdTool class writeKeyword API, which send Dbus request to vpd-manager Dbus service, who hosts the writeKeyword interface to update keyword's value. Whether the user gives Dbus object path or hardware path internally both primary and backup paths gets updated. Testing: Tested for both DBus object path and EEPROM path’s, observed that keyword’s values get updated in both primary and secondary paths. Signed-off-by: Anupama B R <[email protected]>
This commit adds code to read keyword’s value from the local file to update keyword’s value. User can provide file path where the value exists using --file option. Signed-off-by: Anupama B R <[email protected]>
branupama
force-pushed
the
vpd-tool_WR_input_file
branch
from
5875003 to
8cd83d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.