Vpd tool write keyword #499
Open
+185
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
branupama
force-pushed
the
vpd-tool_WriteKeyword
branch
from
0e4ffd1 to
66171f7
Compare
branupama
requested review from
PriyangaRamasamy,
SunnySrivastava1984,
jinuthomas,
souvik1914581 and
RekhaAparna01
branupama
force-pushed
the
vpd-tool_WriteKeyword
branch
from
66171f7 to
4792c1c
Compare
branupama
force-pushed
the
vpd-tool_WriteKeyword
branch
2 times, most recently
from
dfcecb9 to
197757b
Compare
In our current code, For Bonnell like systems, the Backup path doesn't get updated (#516) . We should mention this here? |
| /** | ||
| * @brief API to write keyword's value. | ||
| * | ||
| * This API writes keyword's value by requesting DBus service(vpd-manager) who |
There was a problem hiding this comment.
hosts the 'WriteKeyword' interface to update keyword's value.
WriteKeyword is a DBus method and not an interface?
Not required here, thats can independently exists as issue if so. |
branupama
force-pushed
the
vpd-tool_WriteKeyword
branch
from
197757b to
ce1fb9e
Compare
This commit implements VpdTool class writeKeyword API, which send Dbus request to vpd-manager Dbus service, who hosts the writeKeyword method to update keyword's value. Whether the user gives Dbus object path or hardware path, primary and backup, redundant EEPROM(if any) paths will get updated with given key value. Testing: Tested for both DBus object path and EEPROM path’s, observed that keyword’s values get updated in both primary and secondary paths. Signed-off-by: Anupama B R <[email protected]>
branupama
force-pushed
the
vpd-tool_WriteKeyword
branch
from
ce1fb9e to
59ff39e
Compare
RekhaAparna01
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.